Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL - Separate multiple inherited interfaces with & #324

Conversation

jamesdphillips
Copy link
Contributor

Previously interfaces were implemented with:

type Foo implements Bar, Baz { field: Type }

Replaced by:

type Foo implements Bar & Baz { field: Type }

Closely mirrors reference implementation: graphql/graphql-js#1169.

Previously interfaces were implemented with:

```graphql
type Foo implements Bar, Baz { field: Type }
```

Replaced by:

```graphql
type Foo implements Bar & Baz { field: Type }
```

Signed-off-by: James Phillips <jamesdphillips@gmail.com>
@coveralls
Copy link

coveralls commented May 16, 2018

Coverage Status

Coverage remained the same at 91.801% when pulling eddb712 on jamesdphillips:inherit-multiple-interfaces-syntax into 0821857 on graphql-go:master.

@chris-ramon chris-ramon reopened this Jul 19, 2018
@chris-ramon
Copy link
Member

LGTM 👍 — thanks a lot @jamesdphillips!

@chris-ramon chris-ramon merged commit 83f0349 into graphql-go:master Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants