Fixes #340. Thunk results are completed as per non-thunk results. #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sults. Note that the following tests previously passed and have been modified. * TestLists_NullableListOfNonNullArrayOfFunc_ContainsNulls * TestLists_NonNullListOfNonNullArrayOfFunc_ContainsNulls It seems to me that both of these tests should have failed previously, as they involved passing nil values where nil values were not permitted.
Left a comment to include when support for go1.8 is dropped, as this is useful for identifying the real location of the error.
|
Reading the GraphQL spec (June 2018), section 3.12.1.
This PR changes the test to return the result consistent with the GraphQL spec. When it comes to the test
This one might not be quite as compliant, but it is closer than the test prior to this PR. Please advise if anyone has a different understanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the following tests previously passed and have been modified.
It seems to me that both of these tests should have failed previously, as they involved passing nil values where nil values were not permitted. Please advise if my understanding is incorrect.