Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify assignments with <op>= syntax #376

Merged
merged 1 commit into from
Jul 31, 2018
Merged

simplify assignments with <op>= syntax #376

merged 1 commit into from
Jul 31, 2018

Conversation

quasilyte
Copy link
Contributor

x = x + 1 => x += 1 => x++
x = x / 10 => x /= 10
etc.

Found usign gocritic check called assignOp

@quasilyte
simplify assignments with <op>= syntax
88db909 
x = x + 1 => x += 1 => x++
x = x / 10 => x /= 10
etc.

Found usign gocritic check called assignOp
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.916% when pulling 88db909 on Quasilyte:quasilyte/assignOp into 0403491 on graphql-go:master.

@chris-ramon
Copy link
Member

LGTM 👍 — thanks a lot @quasilyte!

@chris-ramon chris-ramon merged commit 5c1be08 into graphql-go:master Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quasilyte @coveralls @chris-ramon