Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic when mutations or subscriptions is not configured #431

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Fix panic when mutations or subscriptions is not configured #431

merged 1 commit into from
Mar 7, 2019

Conversation

linniksa
Copy link
Contributor

@linniksa linniksa commented Jan 3, 2019

when call

mutation { a }

on schema that mutations is not configured, i got:

{
  "data": null,
  "errors": [
    {
      "message": "runtime error: invalid memory address or nil pointer dereference",
      "locations": []
    }
  ]
}

this PR fix that

@coveralls
Copy link

coveralls commented Jan 3, 2019

Coverage Status

Coverage increased (+0.4%) to 92.237% when pulling 90fefa5 on linniksa:fix-unsupported-operation-error into 21fe71d on graphql-go:master.

@chris-ramon
Copy link
Member

LGTM 👍 It aligns with the graphql-js reference implementation. — Thanks a lot @linniksa!

@chris-ramon chris-ramon merged commit a5c80ac into graphql-go:master Mar 7, 2019
@linniksa linniksa deleted the fix-unsupported-operation-error branch March 7, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants