Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify lexer.TokenType #433

Merged
merged 3 commits into from
Mar 9, 2019
Merged

simplify lexer.TokenType #433

merged 3 commits into from
Mar 9, 2019

Conversation

linniksa
Copy link
Contributor

@linniksa linniksa commented Jan 3, 2019

This also speeds up lexer a bit

@coveralls
Copy link

coveralls commented Jan 3, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 92.237% when pulling bf9cc37 on linniksa:pr-simplify-lexer into a5c80ac on graphql-go:master.

@chris-ramon
Copy link
Member

Hi @linniksa, thanks a lot for your contribution!

LGTM 👍 — This is a neat improvement! def. better to use constant integers rather than accessing map values performance wise. 🚀 💯

@chris-ramon chris-ramon merged commit d902887 into graphql-go:master Mar 9, 2019
@linniksa linniksa deleted the pr-simplify-lexer branch March 10, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-ramon chris-ramon chris-ramon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linniksa @coveralls @chris-ramon