Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BindFields Improvement #503

Merged
merged 2 commits into from
Aug 15, 2020
Merged

BindFields Improvement #503

merged 2 commits into from
Aug 15, 2020

Conversation

jekiapp
Copy link
Contributor

@jekiapp jekiapp commented Aug 21, 2019

BindFields now will treat implementor of interface encoding.TextMarshaler as graphql.String. This will give ability to use time.Time or any encoding.TextMarshaler as a field type.

Issue ref:
#415

@coveralls
Copy link

coveralls commented Aug 21, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 92.391% when pulling 4452f5e on jekiapp:improve_bindfields into 9441c49 on graphql-go:master.

@jekiapp jekiapp mentioned this pull request Aug 21, 2019
Closed
@yoursunny
Copy link

I ran into the time.Time issue today. Can the maintainer merge this PR?

@chris-ramon
Copy link
Member

LGTM 👍 –– Thanks a lot @jekiapp 💯 🚢

@chris-ramon chris-ramon merged commit 33f0862 into graphql-go:master Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoursunny yoursunny yoursunny approved these changes

@chris-ramon chris-ramon chris-ramon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jekiapp @coveralls @yoursunny @chris-ramon