Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scalar parse float issue #510 #511

Merged
merged 2 commits into from
Sep 23, 2019
Merged

Fix scalar parse float issue #510 #511

merged 2 commits into from
Sep 23, 2019

Conversation

lspgn
Copy link
Contributor

@lspgn lspgn commented Sep 17, 2019

As listed in #510, this would fix the parsing issue.

@lspgn lspgn mentioned this pull request Sep 17, 2019
Closed
@coveralls
Copy link

coveralls commented Sep 17, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 92.36% when pulling b6d2bbc on lspgn:louis/fix-scalar-issue into b06cae7 on graphql-go:master.

@chris-ramon
Copy link
Member

LGTM 👍 — Thanks for fixing it @lspgn.

Just for the records there was a previous PR that partially fixed this: #334

Also based on previous comments on related issues it validates that this PR's change is correct.

@chris-ramon chris-ramon self-requested a review September 23, 2019 03:16
@chris-ramon chris-ramon merged commit 5fa0612 into graphql-go:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-ramon chris-ramon chris-ramon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lspgn @coveralls @chris-ramon