Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ParseValue #656

Merged

Conversation

victor-perov
Copy link
Contributor

This PR marks ParseValue as a public method that allows it to be called directly. It is handy to get AST value as part of pre-processing / validation process.

This PR marks ParseValue as a public method that allows it to be
called directly. It is handy to get AST value as part of
pre-processing / validation process.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.051% when pulling 2ce8c8b on victor-perov:victor/expose-ParseValue into 09272f3 on graphql-go:master.

@victor-perov victor-perov mentioned this pull request Nov 16, 2022
@victor-perov
Copy link
Contributor Author

Hi @chris-ramon @sogko!
Would you mind taking a look at this PR, please? I would appreciate if we can get it merged.

Kind regards,
Victor

@victor-perov
Copy link
Contributor Author

Is there any chance this change can be reviewed?

Copy link
Member

@chris-ramon chris-ramon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chris-ramon
Copy link
Member

Thanks a lot @victor-perov

@chris-ramon chris-ramon merged commit 55311b1 into graphql-go:master Feb 25, 2023
@victor-perov
Copy link
Contributor Author

Thanks for merging, @chris-ramon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants