Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not report operations that don't pass GraphQL validation #3809

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

n1ru4l
Copy link
Contributor

@n1ru4l n1ru4l commented Jan 16, 2024

Background

Requires dotansimha/graphql-yoga#3164 for properly handling response cache compatibility.

Closes #3807

Description

Checklist

  • Input validation
  • Output encoding
  • Authentication management
  • Session management
  • Access control
  • Cryptographic practices
  • Error handling and logging
  • Data protection
  • Communication security
  • System configuration
  • Database security
  • File management
  • Memory management
  • Testing

Copy link

changeset-bot bot commented Jan 16, 2024

🦋 Changeset detected

Latest commit: 0296755

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-hive/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 16, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/client 0.28.1-alpha-20240117100704-0296755a1ea7ac7507d3cd239be65f5996f362c3 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Jan 16, 2024

🐋 This PR was built and pushed to the following Docker images (tag: 0296755a1ea7ac7507d3cd239be65f5996f362c3):

Docker Bake metadata
{
"app": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:88ef24342a3a10cf5939d1d9cfc927fc5065be5cbd2094ccd13f902c0ead252c",
    "size": 685
  },
  "containerimage.digest": "sha256:88ef24342a3a10cf5939d1d9cfc927fc5065be5cbd2094ccd13f902c0ead252c",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/app:0296755a1ea7ac7507d3cd239be65f5996f362c3,ghcr.io/kamilkisiela/graphql-hive/app:fix_pass_validation"
},
"composition-federation-2": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:7c94b172b2ca988c456835e1b912e39a03c6239cb0769c12abac135028ea2181",
    "size": 685
  },
  "containerimage.digest": "sha256:7c94b172b2ca988c456835e1b912e39a03c6239cb0769c12abac135028ea2181",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/composition-federation-2:0296755a1ea7ac7507d3cd239be65f5996f362c3,ghcr.io/kamilkisiela/graphql-hive/composition-federation-2:fix_pass_validation"
},
"emails": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:02973d02396f6ea45ea66950324275c29eec38e4555bc9e4af2aed0cc3491774",
    "size": 685
  },
  "containerimage.digest": "sha256:02973d02396f6ea45ea66950324275c29eec38e4555bc9e4af2aed0cc3491774",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/emails:0296755a1ea7ac7507d3cd239be65f5996f362c3,ghcr.io/kamilkisiela/graphql-hive/emails:fix_pass_validation"
},
"policy": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:1f40b89245dd36300f49ef43fb689853d614a399588a2b0a307ba218b8b095f4",
    "size": 685
  },
  "containerimage.digest": "sha256:1f40b89245dd36300f49ef43fb689853d614a399588a2b0a307ba218b8b095f4",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/policy:0296755a1ea7ac7507d3cd239be65f5996f362c3,ghcr.io/kamilkisiela/graphql-hive/policy:fix_pass_validation"
},
"rate-limit": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:388cce156b37c09ee9155c8921c3c2367796232dac6c02927f93f3b7c557af58",
    "size": 685
  },
  "containerimage.digest": "sha256:388cce156b37c09ee9155c8921c3c2367796232dac6c02927f93f3b7c557af58",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/rate-limit:0296755a1ea7ac7507d3cd239be65f5996f362c3,ghcr.io/kamilkisiela/graphql-hive/rate-limit:fix_pass_validation"
},
"schema": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:9fb05247b32d1ba10eecec029d754009b22c9b966da600673defdb916060c610",
    "size": 685
  },
  "containerimage.digest": "sha256:9fb05247b32d1ba10eecec029d754009b22c9b966da600673defdb916060c610",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/schema:0296755a1ea7ac7507d3cd239be65f5996f362c3,ghcr.io/kamilkisiela/graphql-hive/schema:fix_pass_validation"
},
"server": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:91fe8bad6c27f728e54d308178bf5668ddcc2419f62bc09d4084bb57b8c4801b",
    "size": 685
  },
  "containerimage.digest": "sha256:91fe8bad6c27f728e54d308178bf5668ddcc2419f62bc09d4084bb57b8c4801b",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/server:0296755a1ea7ac7507d3cd239be65f5996f362c3,ghcr.io/kamilkisiela/graphql-hive/server:fix_pass_validation"
},
"storage": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:3c8ed2bcb41d59a33d236bcd6b66f861dd1f5f8c32ac30265b0e168ad1b38ed8",
    "size": 685
  },
  "containerimage.digest": "sha256:3c8ed2bcb41d59a33d236bcd6b66f861dd1f5f8c32ac30265b0e168ad1b38ed8",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/storage:0296755a1ea7ac7507d3cd239be65f5996f362c3,ghcr.io/kamilkisiela/graphql-hive/storage:fix_pass_validation"
},
"stripe-billing": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:2220adba08c30699c9a1b2b81df0a5c3e1a890099801e2ad6a2b11208c6d614b",
    "size": 685
  },
  "containerimage.digest": "sha256:2220adba08c30699c9a1b2b81df0a5c3e1a890099801e2ad6a2b11208c6d614b",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/stripe-billing:0296755a1ea7ac7507d3cd239be65f5996f362c3,ghcr.io/kamilkisiela/graphql-hive/stripe-billing:fix_pass_validation"
},
"tokens": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:fc734bf6d214b36fb65b62bde1f153844d33b6ca62baca339764f9e7f120b589",
    "size": 685
  },
  "containerimage.digest": "sha256:fc734bf6d214b36fb65b62bde1f153844d33b6ca62baca339764f9e7f120b589",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/tokens:0296755a1ea7ac7507d3cd239be65f5996f362c3,ghcr.io/kamilkisiela/graphql-hive/tokens:fix_pass_validation"
},
"usage": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:699c47b04011594e80eb19d8fabd672274b7abeb5d17da6eca75c7bc57810721",
    "size": 685
  },
  "containerimage.digest": "sha256:699c47b04011594e80eb19d8fabd672274b7abeb5d17da6eca75c7bc57810721",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/usage:0296755a1ea7ac7507d3cd239be65f5996f362c3,ghcr.io/kamilkisiela/graphql-hive/usage:fix_pass_validation"
},
"usage-estimator": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:8e2205a7bd20133d2885b889d6157d9318e4f88c22b3856eb95f1cb7aa14a090",
    "size": 685
  },
  "containerimage.digest": "sha256:8e2205a7bd20133d2885b889d6157d9318e4f88c22b3856eb95f1cb7aa14a090",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/usage-estimator:0296755a1ea7ac7507d3cd239be65f5996f362c3,ghcr.io/kamilkisiela/graphql-hive/usage-estimator:fix_pass_validation"
},
"usage-ingestor": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:27e2ba680396111fccc9d0f683b41dd7df44f5db68adf675b848422bf4d1593a",
    "size": 685
  },
  "containerimage.digest": "sha256:27e2ba680396111fccc9d0f683b41dd7df44f5db68adf675b848422bf4d1593a",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/usage-ingestor:0296755a1ea7ac7507d3cd239be65f5996f362c3,ghcr.io/kamilkisiela/graphql-hive/usage-ingestor:fix_pass_validation"
},
"webhooks": {
  "containerimage.descriptor": {
    "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
    "digest": "sha256:db7370e651f4f23f077f2ac5e4eab9e9d3628bff3369e60c03cf9c6f28217bc9",
    "size": 685
  },
  "containerimage.digest": "sha256:db7370e651f4f23f077f2ac5e4eab9e9d3628bff3369e60c03cf9c6f28217bc9",
  "image.name": "ghcr.io/kamilkisiela/graphql-hive/webhooks:0296755a1ea7ac7507d3cd239be65f5996f362c3,ghcr.io/kamilkisiela/graphql-hive/webhooks:fix_pass_validation"
}
}

@n1ru4l n1ru4l force-pushed the fix-pass-validation branch 2 times, most recently from 1f3909f to 734d96d Compare January 16, 2024 11:18
@n1ru4l n1ru4l enabled auto-merge (squash) January 16, 2024 14:25
@n1ru4l n1ru4l force-pushed the fix-pass-validation branch from cd6c55d to 0296755 Compare January 16, 2024 14:25
@n1ru4l n1ru4l merged commit b5d1061 into main Jan 17, 2024
25 checks passed
@n1ru4l n1ru4l deleted the fix-pass-validation branch January 17, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

useYogaClient reports schema coordinates of operations that do not pass validation
1 participant