feat: postinstall warning when user has prisma deps #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonkuhrt
commented
Jun 30, 2020
| @@ -1,5 +1,4 @@ | |||
| const chalk = require('chalk') | |||
| const jetpack = require('fs-jetpack') | |||
| const fs = require('fs-jetpack') | |||
There was a problem hiding this comment.
OT
Started to get a bit worried about this being fragile. If not hoisted, we're going to get a runtime error.
| } | ||
|
|
||
| console.log(chalk.bold.yellowBright('----------------------------------')) |
There was a problem hiding this comment.
Don't think this is very helpful anymore and even if we wanted to keep it, would need rethinking now that the packages are merged.
No?
| .filter((name) => !foundPrismaDeps.includes(name)) | ||
| ) | ||
|
|
||
| const message = ` |
There was a problem hiding this comment.
I didn't go with the box design because of variable width content.
jasonkuhrt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes graphql-nexus/nexus#1078