Skip to content

Commit

Permalink
imporove: drop official support for Node 12.x
Browse files Browse the repository at this point in the history
  • Loading branch information
jasonkuhrt committed Jun 22, 2021
1 parent b31c3ef commit 4aaab0e
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 13 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ jobs:
test:
strategy:
matrix:
os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
node-version: [12.x, 14.x, 16.x]
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
node-version: [14.x, 16.x]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
Expand All @@ -50,6 +50,6 @@ jobs:
- run: yarn -s test:ci
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '12.x'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16.x'
with:
directory: ./coverage
6 changes: 3 additions & 3 deletions .github/workflows/trunk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ jobs:
test:
strategy:
matrix:
os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
node-version: [12.x, 14.x, 16.x]
os: ["ubuntu-latest", "macos-latest", "windows-latest"]
node-version: [14.x, 16.x]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
Expand All @@ -29,7 +29,7 @@ jobs:
- run: yarn -s test:ci
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v1
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '12.x'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16.x'
with:
directory: ./coverage

Expand Down
11 changes: 11 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ Official Prisma plugin for Nexus.
- [Project relation with custom resolver logic](#project-relation-with-custom-resolver-logic)
- [Supply custom custom scalars to your GraphQL schema](#supply-custom-custom-scalars-to-your-graphql-schema)
- [Notes](#notes)
- [Supported Versions Of Node & Prisma](#supported-versions-of-node--prisma)

<!-- tocstop -->

Expand Down Expand Up @@ -871,3 +872,13 @@ makeSchema({
- Versions of `nexus-prisma` package prior to `0.20` were a completely different version of the API, and had also become deprecated at one point to migrate to `nexus-plugin-prisma` when Nexus Framework was being worked on. All of that is history.

- If you are using `prisma@=<2.17.x` then you must use the Nexus Prisma Prisma generator name of `nexus_prisma` instead of `nexus-prisma`. This is because prior to `prisma@2.18.x` there was a hardcode check for `nexus-prisma` that would fail with an error message about a now-old migration.

## Supported Versions Of Node & Prisma

We only officially support what we test.

We test Node versions that are `Active LTS` and `Current`. For which versions of Node that equals you can refer to our tests or look here: https://nodejs.org/en/about/releases.

We test Prisma versions `2.25`. More Prisma versions are planned to be tested, refer to [#69](https://github.com/prisma/nexus-prisma/issues/69).

We do not currently maintain a historical matrix of what past versions of Prisma supported what vesrions of Prisma and Node.
8 changes: 1 addition & 7 deletions scripts/get-e2e-db-schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,24 +3,18 @@ import fs from 'fs-jetpack'
import { z } from 'zod'

type ComboCase =
| '12.x + windows-latest'
| '12.x + macos-latest'
| '12.x + ubuntu-latest'
| '14.x + windows-latest'
| '14.x + macos-latest'
| '14.x + ubuntu-latest'
| '16.x + windows-latest'
| '16.x + macos-latest'
| '16.x + ubuntu-latest'

const nodeVersionParser = z.union([z.literal('12.x'), z.literal('14.x'), z.literal('16.x')])
const nodeVersionParser = z.union([z.literal('14.x'), z.literal('16.x')])

const osParser = z.union([z.literal('macos-latest'), z.literal('ubuntu-latest'), z.literal('windows-latest')])

const connectionStringMapping: Record<ComboCase, string> = {
'12.x + macos-latest': 'node_12_macos_latest',
'12.x + windows-latest': 'node_12_windows_latest',
'12.x + ubuntu-latest': 'node_12_ubuntu_latest',
'14.x + macos-latest': 'node_14_macos_latest',
'14.x + windows-latest': 'node_14_windows_latest',
'14.x + ubuntu-latest': 'node_14_ubuntu_latest',
Expand Down

0 comments on commit 4aaab0e

Please sign in to comment.