Fix/resolve tests #207
Fix/resolve tests #207
Conversation
…)" This reverts commit cf59aae. -- Reverting because this caused test regressions throughout the application and we will aim to support ESM officially through Typescript 4.7
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -58,7 +58,7 @@ jobs: | |||
| matrix: | |||
| os: ['ubuntu-latest'] | |||
| node-version: [16.x] | |||
| prisma-client-version: ['3.5'] | |||
| prisma-client-version: ['3.10', '3.11', '3.12', '3.13'] | |||
There was a problem hiding this comment.
Our test now does not support more than one past version test.
Because we have a DB from Heroku to test with and we use schema name for every test by os name and node version here you will use the same schema name so every test will reset the schema for the other one.
we need to update the create schema function to add the prisma version on it.
Please take a look here https://github.com/prisma/nexus-prisma/blob/main/scripts/get-e2e-db-schema.ts
There was a problem hiding this comment.
In case it helps we've implemented e2e tests in @prisma/templates that allow parallel testing on one database server: https://github.com/prisma/templates-node/blob/main/tests/e2e/__testers__.ts
One of the key bits is the clean up operation which is handy for supporting local TDD (doesn't matter much for one-off runs in CI): https://github.com/prisma/templates-node/blob/main/tests/e2e/__testers__.ts#L38
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Extension of #205 that adds to the test matrix and reverts changes from #192 in favor of supporting Typescript ESM using Typescript 4.7. Issue to be created to track that work.
TODO