feat: Don't force async if connection resolvers are sync #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: chore: Prettier on the codebase for JSDoc formatting (#706)
Codecov Report
@@ Coverage Diff @@
## develop #707 +/- ##
========================================
Coverage 93.61% 93.62%
========================================
Files 46 46
Lines 2898 2900 +2
Branches 679 679
========================================
+ Hits 2713 2715 +2
Misses 183 183
Partials 2 2 |
tgriesser
added a commit
that referenced
this pull request
Dec 7, 2020
* develop: feat: Don't force async if connection resolvers are sync (#707) feat: add .asArg for enum, fix default typings (#708) chore: Prettier on the codebase for JSDoc formatting (#706) docs: cover extendType with jsdocs chore(docs): fix nullability yaml frontmatter chore(docs): own guide for nullability docs: cover objectType with jsdocs (#703) chore(docs): fix typo chore(docs): fix typo chore(docs): fix many things in the tutorial chore(docs): fix common to install test deps in tutorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
completeValueinternally in the connection plugin, to avoid adding the overhead of a Promise /asyncfunction call unless it's needed.