feat: remove backward compatible code and warnings #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: - Legacy resolveType is no longer part of the API - Legacy scalar shorthand is not longer possible - declarativeWrappingPlugin is no longer built-in - ScalarInputFieldConfig type is removed
Codecov Report
@@ Coverage Diff @@
## main #730 +/- ##
==========================================
+ Coverage 93.58% 93.77% +0.18%
==========================================
Files 46 46
Lines 2930 2922 -8
Branches 688 688
==========================================
- Hits 2742 2740 -2
+ Misses 186 180 -6
Partials 2 2 |
tgriesser
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
resolveTypeis no longer part of the APII intentionally kept the errors in places where the code path wasn't entirely removed. In these cases, warnings were replaced by throws. Lemme know if you wanna remove the code entirely.