Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DjangoFilterConnectionField type input name consistent with graphene Connection #1316

Closed
tcleonard opened this issue Mar 20, 2022 · 0 comments
Closed

Make DjangoFilterConnectionField type input name consistent with graphene Connection #1316

tcleonard opened this issue Mar 20, 2022 · 0 comments
Assignees
@erikwrede
Labels
✨enhancement

Comments

@tcleonard
Copy link
Collaborator

in graphene the connection type input variable is named _type. We should be consistent in graphene-django
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this issue Mar 20, 2022
feat: update name of DjangoFilterConnectionField type input to be con…
13f9262 
…sistent with graphene (Issue graphql-python#1316)
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this issue Mar 20, 2022
feat: update name of DjangoFilterConnectionField type input to be con…
7d0188f 
…sistent with graphene (Issue graphql-python#1316)
tcleonard added a commit to loft-orbital/graphene-django that referenced this issue Mar 20, 2022
@tcleonard
Merge pull request #14 from loft-orbital/users/tcleonard/graphql-pyth…
4e36aa5 
…on#1316-consistent-type-input-variable-loft

feat: update name of DjangoFilterConnectionField type input to be consistent with graphene (Issue graphql-python#1316)
@tcleonard tcleonard changed the title Make DjangoFilterConnectionField type input name with graphene Connection Make DjangoFilterConnectionField type input name consistent with graphene Connection Mar 22, 2022
@tcleonard tcleonard mentioned this issue Sep 19, 2022
Merged
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this issue Sep 19, 2022
feat: update name of DjangoFilterConnectionField type input to be con…
16f3366 
…sistent with graphene (Issue graphql-python#1316)
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this issue Sep 19, 2022
feat: update name of DjangoFilterConnectionField type input to be con…
9c646e6 
…sistent with graphene (Issue graphql-python#1316)
tcleonard pushed a commit to loft-orbital/graphene-django that referenced this issue Sep 19, 2022
feat: update name of DjangoFilterConnectionField type input to be con…
978430f 
…sistent with graphene (Issue graphql-python#1316)
tcleonard added a commit that referenced this issue Sep 22, 2022
@tcleonard
feat: update name of DjangoFilterConnectionField type input to be con…
a53ded6 
…sistent with graphene (Issue #1316) (#1317)

Co-authored-by: Thomas Leonard <thomas@loftorbital.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikwrede erikwrede

Labels
✨enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@firaskafri @erikwrede @tcleonard