Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation references: op_name -> operation_name #1312

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Fix documentation references: op_name -> operation_name #1312

merged 1 commit into from
Mar 3, 2022

Conversation

pifantastic
Copy link
Contributor

The documentation makes several references to an op_name kwarg that is actually operation_name.

@ulgens ulgens self-requested a review March 3, 2022 08:33
@ulgens
Copy link
Collaborator

ulgens commented Mar 3, 2022

@pifantastic Welcome 🥳

The PR seems good to me. Do we have the same problem with v2 branch?

@pifantastic
Copy link
Contributor Author

@ulgens Seems like the v2 branch is still using op_name and the docs correctly reflect that:

https://github.com/graphql-python/graphene-django/blob/v2/graphene_django/utils/testing.py#L72

@ulgens ulgens merged commit f6ec068 into graphql-python:main Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulgens ulgens ulgens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pifantastic @ulgens