Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync trove classifiers with tox.ini #1341

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Sync trove classifiers with tox.ini #1341

merged 2 commits into from
Sep 2, 2022

Conversation

ulgens
Copy link
Collaborator

@ulgens ulgens commented Aug 20, 2022

No description provided.

@ulgens ulgens requested a review from erikwrede August 20, 2022 12:56
@ulgens
Copy link
Collaborator Author

ulgens commented Aug 22, 2022

@erikwrede @nikolaik 👋🏻 🌷

Copy link
Contributor

@nikolaik nikolaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Should we also go ahead with some of the changes in #1337 ?

setup.py Outdated
@@ -19,7 +19,6 @@
"coveralls",
"mock",
"pytz",
"django-filter<2;python_version<'3'",
"django-filter>=2;python_version>='3'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be unconditional now, since we are python 3 only?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ulgens
Copy link
Collaborator Author

ulgens commented Aug 22, 2022

Should we also go ahead with some of the changes in #1337 ?

This PR for the legacy v2 branch. We can handle similar changes for main in a different one.

@nikolaik
Copy link
Contributor

Should we also go ahead with some of the changes in #1337 ?

This PR for the legacy v2 branch. We can handle similar changes for main in a different one.

Ah, I see, then this makes sense

@ulgens ulgens requested a review from nikolaik August 22, 2022 08:44
@ulgens ulgens merged commit ede3880 into v2 Sep 2, 2022
@ulgens ulgens deleted the sync-trove-tox branch September 2, 2022 15:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants