-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support base class relations and reverse for proxy models #1380
Merged
firaskafri
merged 14 commits into
graphql-python:main
from
TomsOverBaghdad:proxy-model-supports-reverse-relationship
Jul 18, 2023
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b08f2d6
support reverse relationship for proxy models
TomsOverBaghdad 88fe247
Merge branch 'main' into proxy-model-supports-reverse-relationship
firaskafri d009f35
support multi table inheritence
TomsOverBaghdad 54f48b3
update query test for multi table inheritance
TomsOverBaghdad 50ebf76
remove debugger
TomsOverBaghdad 264b84a
support local many to many in model inheritance
TomsOverBaghdad 6ae6362
format and lint
TomsOverBaghdad ac660ea
Merge branch 'main' into proxy-model-supports-reverse-relationship
firaskafri 8764991
Merge branch 'main' into proxy-model-supports-reverse-relationship
TomsOverBaghdad 9080dd8
Merge branch 'main' into proxy-model-supports-reverse-relationship
firaskafri 5394f49
Merge branch 'main' into proxy-model-supports-reverse-relationship
firaskafri 2900d44
Merge branch 'main' into proxy-model-supports-reverse-relationship
firaskafri 19decd3
Merge branch 'main' into proxy-model-supports-reverse-relationship
firaskafri 5b5fca4
Merge branch 'main' into proxy-model-supports-reverse-relationship
firaskafri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomsOverBaghdad this being inside a loop for base classes will break relations in the case of m2m, I think its safer to isolate getting base fields in a different method as in this case
ManyToManyRel
is two sided, in the case ofA
it isManyToManyRel.related
while in the case of B(A) it isManyToManyRel.field
. Check this outTry having the m2m field in the base class just like the example you mentioned in the comment, not a reverse relation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this:
But my preference would still be to get base models relations and reverse relations in a different method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heard! Good catch @firaskafri ! Let me know what you think of the changes I pushed. I separated out getting local fields and included the models ancestry similar to the reverse fields.