Set pypi GH action version to release/v1 #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd say it's better to keep it pinned, but activate automatic update checks. |
|
Not a big issue so I'm fine either way and I also don't think there's much of a difference between 2 approaches, but also this is how we set the versions of other actions as well, |
ulgens
approved these changes
May 27, 2023
firaskafri
approved these changes
May 27, 2023
superlevure
pushed a commit
to loft-orbital/graphene-django
that referenced
this pull request
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it always uses the latest v1 release. We don't have to manually bump the minor and patch version. That's what the doc recommends anyway.