Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows field's choices to be a callable #1497

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Conversation

nossila
Copy link
Contributor

@nossila nossila commented Feb 7, 2024

Starting in Django 5 field's choices can also be a callable https://docs.djangoproject.com/en/5.0/ref/models/fields/#django.db.models.Field.choices

Starting in Django 5 field's choices can also be a callable
@kiendang
Copy link
Collaborator

kiendang commented Feb 7, 2024

Thanks @nossila could you also add a test for this?

Copy link
Collaborator

@kiendang kiendang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @nossila!

Copy link
Collaborator

@sjdemartini sjdemartini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@kiendang kiendang merged commit 45c2aa0 into graphql-python:main Mar 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants