fix: Fix broken 'get_choices' with restframework 3.15.0 #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiendang
approved these changes
Mar 17, 2024
diogosilva30
changed the title
sjdemartini
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest changes in restframework 3.15.0 (Release notes), it looks like the
get_choicesfield inconverter.pyfile is broken when provided with integer choices. I looked into it and the cause was that rest-framework is no longer usingOrderedDict, and instead providing a regulardict, which causes the current code to miss the following if statement:Simply switching
OrderedDicttodictshould suffice and be retro-compatible, since anOrderedDictis ultimately a dictionary. I have tested this change and it works.