Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DjangoObjectType to have default meta #379

Merged
merged 4 commits into from
Feb 2, 2018
Merged

Allow DjangoObjectType to have default meta #379

merged 4 commits into from
Feb 2, 2018

Conversation

mongkok
Copy link
Contributor

@mongkok mongkok commented Jan 21, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 93.582% when pulling 167d0a3 on mongkok:default-meta into e05f069 on graphql-python:master.

@coveralls
Copy link

coveralls commented Jan 21, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.007%) to 93.582% when pulling 3051374 on mongkok:default-meta into 53546a2 on graphql-python:master.

@patrick91
Copy link
Member

patrick91 commented Feb 1, 2018 •
edited
Loading

@mongkok can you rebase from master and add a test? :)

@mongkok mongkok changed the title Allow DjangoObjectType to have default _meta Allow DjangoObjectType to have default meta Feb 2, 2018
@mongkok
Copy link
Contributor Author

mongkok commented Feb 2, 2018

hi @patrick91, I have already included the test :)

@patrick91
Copy link
Member

Thanks :) I'll leave @graphql-python/django to review and merge

@syrusakbary syrusakbary merged commit e827b10 into graphql-python:master Feb 2, 2018
@mongkok mongkok mentioned this pull request Feb 4, 2018
Merged
@mongkok mongkok mentioned this pull request Mar 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mongkok @coveralls @patrick91 @syrusakbary