Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(converter): wrap field with NonNull if it is required #545

Merged
merged 2 commits into from
Jun 10, 2020
Merged

fix(converter): wrap field with NonNull if it is required #545

merged 2 commits into from
Jun 10, 2020

Conversation

helloqiu
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.518% when pulling bc3d9e5 on helloqiu:master into f76f38e on graphql-python:master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.518% when pulling bc3d9e5 on helloqiu:master into f76f38e on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.518% when pulling bc3d9e5 on helloqiu:master into f76f38e on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.518% when pulling bc3d9e5 on helloqiu:master into f76f38e on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.518% when pulling bc3d9e5 on helloqiu:master into f76f38e on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.518% when pulling bc3d9e5 on helloqiu:master into f76f38e on graphql-python:master.

@coveralls
Copy link

coveralls commented Oct 24, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 92.718% when pulling 437b263 on helloqiu:master into b0cba39 on graphql-python:master.

@dulmandakh
Copy link
Contributor

@helloqiu could you please rebase and resolve the conflict. Thank you

@helloqiu
Copy link
Contributor Author

@dulmandakh Sure.

zbyte64
zbyte64 approved these changes May 24, 2019
View reviewed changes
Copy link
Collaborator

@zbyte64 zbyte64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems logical to me, just make sure this gets its own minor version (ie 2.3) release as I don't think this is backwards compatible.

@stale
Copy link

stale bot commented Jul 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 23, 2019
@stale stale bot closed this Jul 30, 2019
@jarcoal
Copy link

jarcoal commented Jun 10, 2020

Any interest in reopening this PR? The bug it fixes is still present in the codebase.

@jkimbo jkimbo reopened this Jun 10, 2020
@stale stale bot removed the wontfix label Jun 10, 2020
@jkimbo jkimbo added the 🐛bug label Jun 10, 2020
@jkimbo jkimbo merged commit 48bfc39 into graphql-python:master Jun 10, 2020
@jkimbo
Copy link
Member

jkimbo commented Jun 25, 2020

Released in v2.11.0

@Akkarine Akkarine mentioned this pull request Feb 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbyte64 zbyte64 zbyte64 approved these changes

Assignees
No one assigned
Labels
🐛bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@helloqiu @coveralls @dulmandakh @jarcoal @jkimbo @zbyte64