Set converted Django connections to required #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkirsz
force-pushed
the
fix-django-connection-field-required
branch
from
e9745bc
to
85313cf
Compare
phalt
suggested changes
Apr 1, 2019
|
@alexkirsz please address code comments :) |
|
@phalt Done! |
phalt
approved these changes
May 2, 2019
mvanlonden
approved these changes
Jun 15, 2019
|
Thanks @alexkirsz. Once rebased we can merge this! |
|
#681 is related to the PR and should probably be merged before this one (it's a smaller subset of these changes). |
alexkirsz
force-pushed
the
fix-django-connection-field-required
branch
from
0c26396
to
0bfe158
Compare
|
@phalt @mvanlonden @jkimbo I just rebased on master and fixed existing conflicts. |
alexkirsz
force-pushed
the
fix-django-connection-field-required
branch
from
0bfe158
to
2bec63a
Compare
This was referenced Aug 1, 2019
Merged
8 tasks
open-dynaMIX
added a commit
to projectcaluma/caluma
that referenced
this pull request
Aug 29, 2019
This commit updates the schema snapshot after upgrading graphene-django from 2.4.0 to 2.5.0. PR that led to this: graphql-python/graphene-django#610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why they're currently nullable, since I believe the default resolver implementation isn't.
Depends upon #609