Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow string references in DjangoListField #885

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Allow string references in DjangoListField #885

merged 2 commits into from
Mar 13, 2020

Conversation

jkimbo
Copy link
Member

@jkimbo jkimbo commented Feb 23, 2020

Fixes #792

@jkimbo jkimbo requested a review from zbyte64 February 23, 2020 09:46
@jkimbo jkimbo mentioned this pull request Feb 23, 2020
Closed
zbyte64
zbyte64 approved these changes Feb 24, 2020
View reviewed changes
Copy link
Collaborator

@zbyte64 zbyte64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where the import happens but I see it is passing the test.

@jkimbo jkimbo merged commit c8a56f8 into master Mar 13, 2020
@jkimbo jkimbo deleted the fix-792 branch March 13, 2020 10:05
@jkimbo
Copy link
Member Author

jkimbo commented Mar 13, 2020

@zbyte64 it happens in the Graphene: https://github.com/graphql-python/graphene/blob/8e7d76bbce3eb8755bf4f3beba8b9d8b026c6424/graphene/types/utils.py#L38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbyte64 zbyte64 zbyte64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2.5.0 to 2.6.0 error: TypeError: issubclass() arg 1 must be a class
2 participants
@jkimbo @zbyte64