Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to_const function from Graphene into Graphene-Django #992

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Move to_const function from Graphene into Graphene-Django #992

merged 2 commits into from
Jun 25, 2020

Conversation

jkimbo
Copy link
Member

@jkimbo jkimbo commented Jun 24, 2020

This PR moves the to_const string converter function from the Graphene project into the Graphene-Django one because it is only used in the Graphene-Django project. See: graphql-python/graphene#1208

This was referenced Jun 24, 2020
Merged
Closed
@jkimbo jkimbo requested review from ulgens and rhizoome June 25, 2020 09:19
rhizoome
rhizoome approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@rhizoome rhizoome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing the dependency down from graphene down to graphene_django makes sense if is not used graphene 👍

@jkimbo jkimbo merged commit 1bec8e4 into master Jun 25, 2020
@jkimbo jkimbo deleted the add-to-const-function branch June 25, 2020 14:11
@jkimbo
Copy link
Member Author

jkimbo commented Jun 25, 2020

Released in v2.11.0

@noelleleigh
Copy link
Contributor

Can this patch also be applied to the v3 branch? I'm getting an import error after installing graphene-django 3.0.0b3, which installed graphene 3.0.0b3:

File "/usr/local/lib/python3.6/dist-packages/graphene_django/converter.py", line 25, in <module>
    from graphene.utils.str_converters import to_camel_case, to_const
ImportError: cannot import name 'to_const'

@rhizoome rhizoome mentioned this pull request Jun 26, 2020
Merged
jkimbo added a commit that referenced this pull request Jun 27, 2020
@jkimbo
Move to_const function from Graphene into Graphene-Django (#992) (#996)
08d0cce 
Co-authored-by: Jonathan Kim <jkimbo@gmail.com>
@jkimbo
Copy link
Member Author

jkimbo commented Jun 27, 2020

@noelleleigh just released v3.0.0b4 that includes this change. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhizoome rhizoome rhizoome approved these changes

@zbyte64 zbyte64 Awaiting requested review from zbyte64

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

@ekampf ekampf Awaiting requested review from ekampf

@mvanlonden mvanlonden Awaiting requested review from mvanlonden

@ulgens ulgens Awaiting requested review from ulgens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkimbo @noelleleigh @rhizoome