Make Graphene enums iterable like Python enums #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Will test it locally this afternoon and it should be good to merge afterwards! 🙂 |
erikwrede
requested changes
Nov 16, 2022
graphene/tests/issues/test_1264.py
Outdated
Comment on lines
1
to
13
| from graphene.types.enum import Enum | ||
|
|
||
|
|
||
| def test_enum_iteration(): | ||
| class TestEnum(Enum): | ||
| FIRST = 1 | ||
| SECOND = 2 | ||
|
|
||
| result = [] | ||
| expected_values = ["FIRST", "SECOND"] | ||
| for c in TestEnum: | ||
| result.append(c.name) | ||
| assert result == expected_values |
There was a problem hiding this comment.
This would be better-placed in test_enum.py, as this is not really a bug but rather a new "Feature" of the graphene-style enums.
Can you also add this test case for the instance-creation style of enums?
def test_iterable_instance_creation_enum():
TestEnum = Enum("TestEnum", [("FIRST", 1), ("SECOND", 2)])
result = []
expected_values = ["FIRST", "SECOND"]
for c in TestEnum:
result.append(c.name)
assert result == expected_values
erikwrede
force-pushed
the
issue-1264
branch
from
58103af to
ca64b51
Compare
erikwrede
approved these changes
Nov 16, 2022
|
Thank you for the PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Python enums are iterable, the expectation exists that Graphene enums are similarly iterable, as shown in #1264. The proposed solution is to do a straightforward pass-through of the underlying Python enum, so that it will behave exactly the same way.
Fixes #1264