Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create v2 that is compatible with Core v2 #21

Merged
merged 5 commits into from
Jul 14, 2019

Conversation

Cito
Copy link
Member

@Cito Cito commented Jul 5, 2019

As discussed on Slack, we need to publish a version 2.0 of graphql-relay that is compatible with GraphQL-Core v2. The current version only supports GraphQL-Core < v2.

The next step will be to publish a version 3.0 that is compatible with GraphQL-Core-Next = GraphQL-Core v3. This version has already been prepared in the "next" branch.

This PR includes the following:

  • Bump version to 2.0
  • Support GraphQL-core >= 2.0, < 3
    (use the newer signature for resolvers)
  • Pin last working version of dependencies
  • Drop support for Python 3.3
  • Drop redundant README.rst
  • House-cleaning and PEP-8

* Bump version to 2.0
* Support GraphQL-core >= 2.0, < 3
  (use the newer signature for resolvers)
* Drop support for Python 3.3
* Drop redundant README.rst
* Clean-up and PEP-8
@coveralls
Copy link

coveralls commented Jul 5, 2019

Coverage Status

Coverage decreased (-0.003%) to 99.633% when pulling c7d1cc9 on Cito:version-2 into 08c5995 on graphql-python:master.

Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. I've added a couple of suggestions but nothing that should block this being released.

setup.cfg Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@Cito Cito merged commit b6bd31c into graphql-python:master Jul 14, 2019
@Cito Cito deleted the version-2 branch July 14, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants