Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Update to thiserror version 2 #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

caspermeijn
Copy link
Contributor

Depencency thiserror has some breaking changes, but non of them seem to impact graphql-parser.

cargo semver-checks reports no changes on the API.

Depencency `thiserror` has some breaking changes, but non of them seem to impact `graphql-parser`.

`cargo semver-checks` reports no changes on the API.
@LegNeato
Copy link
Member

LegNeato commented Dec 8, 2024

Does the new version increase the supported Rust version or is every supported version the same?

@caspermeijn
Copy link
Contributor Author

I didn't mention the MSRV because this repo doesn't specify a MSRV :-)

The MRSV of thiserror is 1.61. It was bumped about a month ago for the v1 series.

Do you want me to create a PR to set the MSRV of this repo to 1.61 as well? Does graphql-rust have a policy for MSRV?

@LegNeato
Copy link
Member

I don't think there is a current policy 🤔. @tailhook may know.

@LegNeato
Copy link
Member

But I think if both the v1 and v2 both bumped the msrv its probably ok to bump here as well. I'll wait a bit for @tailhook and merge if no response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants