Remove transitive dependency on `mio` #1283

SandroHc · 2024-09-07T00:58:03Z

Removes the transitive dependency on mio. This allows projects targeting wasm32-unknown-unknown to compile. Fixes #1282.

The mio dependency is being brought in via: juniper_axum→axum→axum/tokio→tokio/net→mio. By disabling the default features of axum, we disable its tokio feature.

axum's comment on mio:

mio, tokio's IO layer, does not support the wasm32-unknown-unknown target which is why this crate requires default-features = false for axum.

Reproduction Steps

Install the "wasm32-unknown-unknown" target
rustup target add wasm32-unknown-unknown
Create a dummy WASM library
cargo install cargo-generate && cargo generate --git https://github.com/rustwasm/wasm-pack-template
Add "axum"
cargo add axum@0.7.5 --no-default-features
Add "juniper"
cargo add juniper@0.16.1
Confirm that project builds
cargo build --target wasm32-unknown-unknown
cargo tree --target wasm32-unknown-unknown --invert mio (no matches is what we want)
Add "juniper_axum"
cargo add juniper_axum@0.1.0
Project no longer builds
cargo build --target wasm32-unknown-unknown
cargo tree --target wasm32-unknown-unknown --invert mio

Build log & errors

$ cargo build --target wasm32-unknown-unknown                                                                                   5s 09:56:23
   Compiling futures-sink v0.3.30
   Compiling futures-task v0.3.30
   Compiling futures-io v0.3.30
   Compiling slab v0.4.9
   Compiling mio v1.0.2
   Compiling futures-macro v0.3.30
   Compiling tokio-macros v2.4.0
   Compiling httparse v1.9.4
   Compiling tracing-core v0.1.32
   Compiling log v0.4.22
   Compiling axum-core v0.4.3
error[E0432]: unresolved import `crate::sys::IoSourceState`
  --> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/io_source.rs:14:5
   |
14 | use crate::sys::IoSourceState;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^ no `IoSourceState` in `sys`
error[E0432]: unresolved import crate::sys::tcp

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/listener.rs:17:17

|

17 | use crate::sys::tcp::{bind, listen, new_for_addr};

|                 ^^^ could not find tcp in sys
error[E0432]: unresolved import crate::sys::tcp

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/stream.rs:15:17

|

15 | use crate::sys::tcp::{connect, new_for_addr};

|                 ^^^ could not find tcp in sys
error[E0433]: failed to resolve: could not find Selector in sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/poll.rs:321:18

|

321 |             sys::Selector::new().map(|selector| Poll {

|                  ^^^^^^^^ could not find Selector in sys
error[E0433]: failed to resolve: could not find event in sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/event.rs:24:14

|

24 |         sys::event::token(&self.inner)

|              ^^^^^ could not find event in sys
error[E0433]: failed to resolve: could not find event in sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/event.rs:38:14

|

38 |         sys::event::is_readable(&self.inner)

|              ^^^^^ could not find event in sys
error[E0433]: failed to resolve: could not find event in sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/event.rs:43:14

|

43 |         sys::event::is_writable(&self.inner)

|              ^^^^^ could not find event in sys
error[E0433]: failed to resolve: could not find event in sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/event.rs:68:14

|

68 |         sys::event::is_error(&self.inner)

|              ^^^^^ could not find event in sys
error[E0433]: failed to resolve: could not find event in sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/event.rs:99:14

|

99 |         sys::event::is_read_closed(&self.inner)

|              ^^^^^ could not find event in sys
error[E0433]: failed to resolve: could not find event in sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/event.rs:129:14

|

129 |         sys::event::is_write_closed(&self.inner)

|              ^^^^^ could not find event in sys
error[E0433]: failed to resolve: could not find event in sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/event.rs:151:14

|

151 |         sys::event::is_priority(&self.inner)

|              ^^^^^ could not find event in sys
error[E0433]: failed to resolve: could not find event in sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/event.rs:173:14

|

173 |         sys::event::is_aio(&self.inner)

|              ^^^^^ could not find event in sys
error[E0433]: failed to resolve: could not find event in sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/event.rs:183:14

|

183 |         sys::event::is_lio(&self.inner)

|              ^^^^^ could not find event in sys
error[E0433]: failed to resolve: could not find event in sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/event.rs:221:26

|

221 |                     sys::event::debug_details(f, self.0)

|                          ^^^^^ could not find event in sys
error[E0433]: failed to resolve: could not find tcp in sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/listener.rs:105:18

|

105 |             sys::tcp::accept(inner).map(|(stream, addr)| (TcpStream::from_std(stream), addr))

|                  ^^^ could not find tcp in sys
error[E0433]: failed to resolve: could not find udp in sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/udp.rs:124:14

|

124 |         sys::udp::bind(addr).map(UdpSocket::from_std)

|              ^^^ could not find udp in sys
error[E0433]: failed to resolve: could not find udp in sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/udp.rs:546:14

|

546 |         sys::udp::only_v6(&self.inner)

|              ^^^ could not find udp in sys
error[E0412]: cannot find type Selector in module sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/poll.rs:272:20

|

272 |     selector: sys::Selector,

|                    ^^^^^^^^ not found in sys
error[E0412]: cannot find type Selector in module sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/poll.rs:728:44

|

728 |     pub(crate) fn selector(&self) -> &sys::Selector {

|                                            ^^^^^^^^ not found in sys
error[E0412]: cannot find type Waker in module sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/waker.rs:79:17

|

79 |     inner: sys::Waker,

|                 ^^^^^ not found in sys

|

help: consider importing one of these items

|

1  + use core::task::Waker;

|

1  + use crate::Waker;

|

1  + use std::task::Waker;

|

help: if you import Waker, refer to it directly

|

79 -     inner: sys::Waker,

79 +     inner: Waker,

|
error[E0433]: failed to resolve: could not find Waker in sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/waker.rs:87:14

|

87 |         sys::Waker::new(registry.selector(), token).map(|inner| Waker { inner })

|              ^^^^^ could not find Waker in sys

|

help: consider importing one of these items

|

1  + use core::task::Waker;

|

1  + use crate::Waker;

|

1  + use std::task::Waker;

|

help: if you import Waker, refer to it directly

|

87 -         sys::Waker::new(registry.selector(), token).map(|inner| Waker { inner })

87 +         Waker::new(registry.selector(), token).map(|inner| Waker { inner })

|
error[E0412]: cannot find type Event in module sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/event.rs:18:17

|

18 |     inner: sys::Event,

|                 ^^^^^ not found in sys

|

help: consider importing this struct through its public re-export

|

1  + use crate::event::Event;

|

help: if you import Event, refer to it directly

|

18 -     inner: sys::Event,

18 +     inner: Event,

|
error[E0412]: cannot find type Event in module sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/event.rs:187:55

|

187 |     pub(crate) fn from_sys_event_ref(sys_event: &sys::Event) -> &Event {

|                                                       ^^^^^ not found in sys

|

help: consider importing this struct through its public re-export

|

1   + use crate::event::Event;

|

help: if you import Event, refer to it directly

|

187 -     pub(crate) fn from_sys_event_ref(sys_event: &sys::Event) -> &Event {

187 +     pub(crate) fn from_sys_event_ref(sys_event: &Event) -> &Event {

|
error[E0412]: cannot find type Event in module sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/event.rs:191:41

|

191 |             &*(sys_event as *const sys::Event as const Event)

|                                         ^^^^^ not found in sys

|

help: consider importing this struct through its public re-export

|

1   + use crate::event::Event;

|

help: if you import Event, refer to it directly

|

191 -             &(sys_event as *const sys::Event as const Event)

191 +             &(sys_event as *const Event as *const Event)

|
error[E0412]: cannot find type Event in module sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/event.rs:217:46

|

217 |             struct EventDetails<'a>(&'a sys::Event);

|                                              ^^^^^ not found in sys

|

help: consider importing this struct through its public re-export

|

1   + use crate::event::Event;

|

help: if you import Event, refer to it directly

|

217 -             struct EventDetails<'a>(&'a sys::Event);

217 +             struct EventDetails<'a>(&'a Event);

|
error[E0412]: cannot find type Events in module sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/events.rs:43:17

|

43 |     inner: sys::Events,

|                 ^^^^^^ not found in sys

|

help: consider importing this struct through its public re-export

|

1  + use crate::Events;

|

help: if you import Events, refer to it directly

|

43 -     inner: sys::Events,

43 +     inner: Events,

|
error[E0433]: failed to resolve: could not find Events in sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/events.rs:94:25

|

94 |             inner: sys::Events::with_capacity(capacity),

|                         ^^^^^^ could not find Events in sys

|

help: consider importing this struct through its public re-export

|

1  + use crate::Events;

|

help: if you import Events, refer to it directly

|

94 -             inner: sys::Events::with_capacity(capacity),

94 +             inner: Events::with_capacity(capacity),

|
error[E0412]: cannot find type Events in module sys

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/events.rs:189:47

|

189 |     pub(crate) fn sys(&mut self) -> &mut sys::Events {

|                                               ^^^^^^ not found in sys

|

help: consider importing this struct through its public re-export

|

1   + use crate::Events;

|

help: if you import Events, refer to it directly

|

189 -     pub(crate) fn sys(&mut self) -> &mut sys::Events {

189 +     pub(crate) fn sys(&mut self) -> &mut Events {

|
error[E0425]: cannot find value listener in this scope

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/listener.rs:76:24

|

76 |         set_reuseaddr(&listener.inner, true)?;

|                        ^^^^^^^^ not found in this scope
error[E0425]: cannot find value listener in this scope

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/listener.rs:78:15

|

78 |         bind(&listener.inner, addr)?;

|               ^^^^^^^^ not found in this scope
error[E0425]: cannot find value listener in this scope

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/listener.rs:79:17

|

79 |         listen(&listener.inner, 1024)?;

|                 ^^^^^^^^ not found in this scope
error[E0425]: cannot find value listener in this scope

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/listener.rs:80:12

|

80 |         Ok(listener)

|            ^^^^^^^^ not found in this scope
error[E0425]: cannot find value stream in this scope

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/stream.rs:95:18

|

95 |         connect(&stream.inner, addr)?;

|                  ^^^^^^ not found in this scope
error[E0425]: cannot find value stream in this scope

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/stream.rs:96:12

|

96 |         Ok(stream)

|            ^^^^^^ not found in this scope
error[E0425]: cannot find function set_reuseaddr in this scope

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/listener.rs:76:9

|

76 |         set_reuseaddr(&listener.inner, true)?;

|         ^^^^^^^^^^^^^ not found in this scope
Compiling futures-channel v0.3.30

Compiling ryu v1.0.18

error[E0599]: no method named register found for struct IoSource<std::net::TcpListener> in the current scope

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/listener.rs:148:20

|

148 |         self.inner.register(registry, token, interests)

|                    ^^^^^^^^ method not found in IoSource<TcpListener>

|

::: /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/io_source.rs:37:1

|

37  | pub struct IoSource {

| ---------------------- method register not found for this struct

|

= help: items from traits can only be used if the trait is implemented and in scope

note: Source defines an item register, perhaps you need to implement it

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/source.rs:75:1

|

75  | pub trait Source {

| ^^^^^^^^^^^^^^^^
error[E0599]: no method named reregister found for struct IoSource<std::net::TcpListener> in the current scope

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/listener.rs:157:20

|

157 |         self.inner.reregister(registry, token, interests)

|                    ^^^^^^^^^^ method not found in IoSource<TcpListener>

|

::: /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/io_source.rs:37:1

|

37  | pub struct IoSource {

| ---------------------- method reregister not found for this struct

|

= help: items from traits can only be used if the trait is implemented and in scope

note: Source defines an item reregister, perhaps you need to implement it

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/source.rs:75:1

|

75  | pub trait Source {

| ^^^^^^^^^^^^^^^^
error[E0599]: no method named deregister found for struct IoSource<std::net::TcpListener> in the current scope

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/listener.rs:161:20

|

161 |         self.inner.deregister(registry)

|                    ^^^^^^^^^^ method not found in IoSource<TcpListener>

|

::: /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/io_source.rs:37:1

|

37  | pub struct IoSource {

| ---------------------- method deregister not found for this struct

|

= help: items from traits can only be used if the trait is implemented and in scope

note: Source defines an item deregister, perhaps you need to implement it

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/source.rs:75:1

|

75  | pub trait Source {

| ^^^^^^^^^^^^^^^^
error[E0308]: mismatched types

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/listener.rs:237:9

|

237 | /         unsafe {

238 | |             #[cfg(any(unix, target_os = "hermit", target_os = "wasi"))]

239 | |             {

240 | |                 net::TcpListener::from_raw_fd(listener.into_raw_fd())

...   |

245 | |             }

246 | |         }

| |_________^ expected TcpListener, found ()
error[E0599]: no method named register found for struct IoSource<std::net::TcpStream> in the current scope

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/stream.rs:330:20

|

330 |         self.inner.register(registry, token, interests)

|                    ^^^^^^^^ method not found in IoSource<TcpStream>

|

::: /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/io_source.rs:37:1

|

37  | pub struct IoSource {

| ---------------------- method register not found for this struct

|

= help: items from traits can only be used if the trait is implemented and in scope

note: Source defines an item register, perhaps you need to implement it

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/source.rs:75:1

|

75  | pub trait Source {

| ^^^^^^^^^^^^^^^^
error[E0599]: no method named reregister found for struct IoSource<std::net::TcpStream> in the current scope

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/stream.rs:339:20

|

339 |         self.inner.reregister(registry, token, interests)

|                    ^^^^^^^^^^ method not found in IoSource<TcpStream>

|

::: /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/io_source.rs:37:1

|

37  | pub struct IoSource {

| ---------------------- method reregister not found for this struct

|

= help: items from traits can only be used if the trait is implemented and in scope

note: Source defines an item reregister, perhaps you need to implement it

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/source.rs:75:1

|

75  | pub trait Source {

| ^^^^^^^^^^^^^^^^
error[E0599]: no method named deregister found for struct IoSource<std::net::TcpStream> in the current scope

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/stream.rs:343:20

|

343 |         self.inner.deregister(registry)

|                    ^^^^^^^^^^ method not found in IoSource<TcpStream>

|

::: /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/io_source.rs:37:1

|

37  | pub struct IoSource {

| ---------------------- method deregister not found for this struct

|

= help: items from traits can only be used if the trait is implemented and in scope

note: Source defines an item deregister, perhaps you need to implement it

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/source.rs:75:1

|

75  | pub trait Source {

| ^^^^^^^^^^^^^^^^
error[E0308]: mismatched types

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/tcp/stream.rs:419:9

|

419 | /         unsafe {

420 | |             #[cfg(any(unix, target_os = "hermit", target_os = "wasi"))]

421 | |             {

422 | |                 net::TcpStream::from_raw_fd(stream.into_raw_fd())

...   |

427 | |             }

428 | |         }

| |_________^ expected TcpStream, found ()
error[E0599]: no method named register found for struct IoSource<std::net::UdpSocket> in the current scope

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/udp.rs:624:20

|

624 |         self.inner.register(registry, token, interests)

|                    ^^^^^^^^ method not found in IoSource<UdpSocket>

|

::: /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/io_source.rs:37:1

|

37  | pub struct IoSource {

| ---------------------- method register not found for this struct

|

= help: items from traits can only be used if the trait is implemented and in scope

note: Source defines an item register, perhaps you need to implement it

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/source.rs:75:1

|

75  | pub trait Source {

| ^^^^^^^^^^^^^^^^
Compiling serde_json v1.0.128

error[E0599]: no method named reregister found for struct IoSource<std::net::UdpSocket> in the current scope

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/udp.rs:633:20

|

633 |         self.inner.reregister(registry, token, interests)

|                    ^^^^^^^^^^ method not found in IoSource<UdpSocket>

|

::: /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/io_source.rs:37:1

|

37  | pub struct IoSource {

| ---------------------- method reregister not found for this struct

|

= help: items from traits can only be used if the trait is implemented and in scope

note: Source defines an item reregister, perhaps you need to implement it

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/source.rs:75:1

|

75  | pub trait Source {

| ^^^^^^^^^^^^^^^^
error[E0599]: no method named deregister found for struct IoSource<std::net::UdpSocket> in the current scope

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/udp.rs:637:20

|

637 |         self.inner.deregister(registry)

|                    ^^^^^^^^^^ method not found in IoSource<UdpSocket>

|

::: /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/io_source.rs:37:1

|

37  | pub struct IoSource {

| ---------------------- method deregister not found for this struct

|

= help: items from traits can only be used if the trait is implemented and in scope

note: Source defines an item deregister, perhaps you need to implement it

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/event/source.rs:75:1

|

75  | pub trait Source {

| ^^^^^^^^^^^^^^^^
error[E0308]: mismatched types

--> /Users/ts-sandroama.marques/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.2/src/net/udp.rs:713:9

|

713 | /         unsafe {

714 | |             #[cfg(any(unix, target_os = "hermit", target_os = "wasi"))]

715 | |             {

716 | |                 net::UdpSocket::from_raw_fd(socket.into_raw_fd())

...   |

721 | |             }

722 | |         }

| |_________^ expected UdpSocket, found ()
Some errors have detailed explanations: E0308, E0412, E0425, E0432, E0433, E0599.

For more information about an error, try rustc --explain E0308.

error: could not compile mio (lib) due to 47 previous errors

warning: build failed, waiting for other jobs to finish...

This allows projects targeting `wasm32-unknown-unknown` to compile. The `mio` dependency is being brought in via: `juniper_axum`→`axum`→`axum/tokio`→`tokio/net`→`mio`. By disabling the default features of `axum`, we disable its `tokio` feature.

LegNeato · 2024-09-09T20:28:09Z

Thanks! Can we get this added to CI so we don't accidentally regress?

LegNeato

A test in CI so we don't accidentally regress this would be great

tyranron

@SandroHc thanks!

Request satisfied.

SandroHc force-pushed the mio-dep branch from fb2ac45 to 0f7c1ec Compare September 8, 2024 05:22

Merge branch 'master' into mio-dep

b157e3d

LegNeato previously requested changes Sep 18, 2024

View reviewed changes

tyranron assigned SandroHc Sep 23, 2024

tyranron added enhancement Improvement of existing features or bugfix lib::axum Related to `axum` crate integration k::integration Related to integration with third-party libraries or systems labels Sep 23, 2024

tyranron added this to the 0.17.0 milestone Sep 23, 2024

tyranron added 2 commits September 23, 2024 23:25

Merge branch 'master' into mio-dep

647e3cb

Add CI check

3ba86d6

tyranron approved these changes Sep 23, 2024

View reviewed changes

tyranron enabled auto-merge (squash) September 23, 2024 21:03

tyranron merged commit 0e0e6a1 into graphql-rust:master Sep 23, 2024
180 checks passed

tyranron added a commit that referenced this pull request Sep 23, 2024

Mention WASM support in juniper_axum CHANGELOG (#1283, #1282)

86297a4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove transitive dependency on `mio` #1283

Remove transitive dependency on `mio` #1283

SandroHc commented Sep 7, 2024

LegNeato commented Sep 9, 2024 •

edited

Loading

LegNeato left a comment

tyranron left a comment

Remove transitive dependency on mio #1283

Remove transitive dependency on mio #1283

Conversation

SandroHc commented Sep 7, 2024

Reproduction Steps

Build log & errors

LegNeato commented Sep 9, 2024 • edited Loading

LegNeato left a comment

Choose a reason for hiding this comment

tyranron left a comment

Choose a reason for hiding this comment

Remove transitive dependency on `mio` #1283

Remove transitive dependency on `mio` #1283

LegNeato commented Sep 9, 2024 •

edited

Loading