Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ReadonlyArray instead of Array on input args #181

Closed
wants to merge 3 commits into from
Closed

Use ReadonlyArray instead of Array on input args #181

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
440ac39
Use ReadonlyArray instead of Array on input args
ckknight Apr 17, 2019
77df489
Merge branch 'master' into patch-1
leebyron Nov 13, 2019
d0374ec
Use ReadonlyArray in promise result
leebyron Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ declare class DataLoader<K, V, C = K> {
* ]);
*
*/
loadMany(keys: K[]): Promise<V[]>;
loadMany(keys: ReadonlyArray<K>): Promise<V[]>;

/**
* Clears the value at `key` from the cache, if it exists. Returns itself for
Expand Down Expand Up @@ -70,7 +70,8 @@ declare namespace DataLoader {

// A Function, which when given an Array of keys, returns a Promise of an Array
// of values or Errors.
export type BatchLoadFn<K, V> = (keys: K[]) => PromiseLike<Array<V | Error>>;
export type BatchLoadFn<K, V> =
(keys: ReadonlyArray<K>) => PromiseLike<ReadonlyArray<V | Error>>;

// Optionally turn off batching or caching or provide a cache key function or a
// custom cache instance.
Expand Down