Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Batch loads distinct keys with disabled cache. #46

Closed
wants to merge 1 commit into from
Closed

[RFC] Batch loads distinct keys with disabled cache. #46

wants to merge 1 commit into from

Conversation

leebyron
Copy link
Contributor

Based on conversation from #44

@leebyron leebyron mentioned this pull request Sep 24, 2016
Closed
@leebyron leebyron force-pushed the distinct-keys branch 2 times, most recently from 6242cf7 to 67be4f3 Compare September 24, 2016 01:51
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 67be4f3 on distinct-keys into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 67be4f3 on distinct-keys into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 67be4f3 on distinct-keys into * on master*.

@eugene1g eugene1g mentioned this pull request Nov 7, 2016
Closed
@blakeembrey blakeembrey mentioned this pull request Dec 6, 2016
Closed
@nicksrandall nicksrandall mentioned this pull request Jan 30, 2017
Closed
leebyron added a commit that referenced this pull request Feb 4, 2017
@leebyron
Add Readme and tests about cache disabling
db4f2fc 
Based on discussion in #63, a decision was made to not break existing correct but potentially confusing behavior but instead to clearly document that behavior and illustrate patterns for producing different cache behavior such as per-frame caching.

Closes #63
Closes #46
Closes #44
Closes #34
@leebyron leebyron mentioned this pull request Feb 4, 2017
Merged
leebyron added a commit that referenced this pull request Feb 4, 2017
@leebyron
Add Readme and tests about cache disabling
e6cae6d 
Based on discussion in #63, a decision was made to not break existing correct but potentially confusing behavior but instead to clearly document that behavior and illustrate patterns for producing different cache behavior such as per-frame caching.

Closes #63
Closes #46
Closes #44
Closes #34
@leebyron leebyron closed this in #72 Feb 4, 2017
leebyron added a commit that referenced this pull request Feb 4, 2017
@leebyron
Add Readme and tests about cache disabling (#72)
f005123 
Based on discussion in #63, a decision was made to not break existing correct but potentially confusing behavior but instead to clearly document that behavior and illustrate patterns for producing different cache behavior such as per-frame caching.

Closes #63
Closes #46
Closes #44
Closes #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leebyron @coveralls