Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency declaration for graphql-language-service-utils #1944

Closed
oliversalzburg opened this issue Sep 2, 2021 · 3 comments · Fixed by #2023, #2042 or #2049
Closed

Missing dependency declaration for graphql-language-service-utils #1944

oliversalzburg opened this issue Sep 2, 2021 · 3 comments · Fixed by #2023, #2042 or #2049
Labels

Comments

@oliversalzburg
Copy link

graphiql and codemirror-graphql both try to import from graphql-language-service-utils, but do not declare the dependency.

See:

The dependency should be properly declared.

@acao acao added the bug label Sep 10, 2021
@acao
Copy link
Member

acao commented Nov 9, 2021

this should be fixed now

@acao acao closed this as completed Nov 9, 2021
@willstott101
Copy link
Contributor

willstott101 commented Nov 17, 2021

Thanks @acao but it looks like there's been no changes to codemirror-graphql, it still uses graphql-language-service-utils at https://github.com/graphql/graphiql/blob/main/packages/codemirror-graphql/src/hint.ts#L18 without declaring the dep

@acao
Copy link
Member

acao commented Nov 17, 2021

Oops, it’s fixed in a PR, i got this mixed up with another ticket

This was referenced Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants