Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header edit/delete buttons are inaccessible for long headers #256

Closed
robertpeacock22 opened this issue Dec 16, 2016 · 2 comments
Closed

Comments

@robertpeacock22
Copy link

When you add a very long header such as an auth token, the masked token does not wrap. As a result it pushes the edit and delete buttons far off the right side of the page.

In Firefox I can access the buttons by zooming out extremely far.
screen shot 2016-12-16 at 11 26 11 am

In Chrome I'm not even able to zoom out far enough to bring the buttons on screen.

Expected:
Either the position of the buttons should be moved (e.g. just under the header name), or the masked token should wrap lines, leaving space at the right for the buttons.

@wincent wincent added bug and removed bug labels Dec 16, 2016
@wincent
Copy link
Contributor

wincent commented Dec 16, 2016

@robertpeacock22: That looks like it might be a screenshot from https://github.com/OlegIlyenko/graphiql-workspace or similar. Should this be filed against that project instead?

@robertpeacock22
Copy link
Author

You're absolutely correct. My apologies.

acao pushed a commit to acao/graphiql that referenced this issue Jun 5, 2019
…raphql#256)

Drop support for graphql v0.10 and v0.11 as these versions do not contain
`ExecutableDefinitions` (required by
packages/utils/src/validateWithCustomRules.js)

N.b. this will require a major version bump at the next release.

Fixes graphql#239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants