Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more tests for findGraphQLTags, fix cache/schema tests #2533

Merged
merged 1 commit into from
Jul 3, 2022

Conversation

acao
Copy link
Member

@acao acao commented Jul 3, 2022

another boring incremental improvement PR 😆

  • re-enable some tests for GraphQLCache that were disabled after an update to graphql-config after I found a proper mocking workaround
  • add more tests for cases in findGraphQLTags.ts as a follow up to feat: add gql call expressions support #2509

@changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2022

⚠️ No Changeset found

Latest commit: 2b89809

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2022

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #2533 (2b89809) into main (2d91916) will increase coverage by 3.75%.
The diff coverage is 23.64%.

@@            Coverage Diff             @@
##             main    #2533      +/-   ##
==========================================
+ Coverage   65.70%   69.45%   +3.75%     
==========================================
  Files          85       71      -14     
  Lines        5106     4155     -951     
  Branches     1631     1375     -256     
==========================================
- Hits         3355     2886     -469     
+ Misses       1747     1264     -483     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts 5.76% <5.76%> (ø)
packages/codemirror-graphql/src/variables/lint.ts 46.98% <66.66%> (ø)
packages/codemirror-graphql/src/hint.ts 94.73% <100.00%> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 737d418...2b89809. Read the comment docs.

@acao
Copy link
Member Author

acao commented Jul 3, 2022

Nice. Almost a 4% coverage increase!

Screenshot 2022-07-03 at 16 53 43

@acao acao merged commit 66d0437 into main Jul 3, 2022
@acao acao deleted the find-tags-tests branch July 3, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant