Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix search dropdown click #3364

Merged
merged 5 commits into from
Jul 24, 2023
Merged

fix search dropdown click #3364

merged 5 commits into from
Jul 24, 2023

Conversation

acao
Copy link
Member

@acao acao commented Jul 23, 2023

Fixes #3307

Temporarily disable the onBlur behavior, because it's more important to have the search results clickable than to dismiss the dropdown onBlur - already, simply by clicking outside the dropdown, you can dismiss it.

@changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2023

🦋 Changeset detected

Latest commit: 14c1972

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
graphiql Patch
@graphiql/react Patch
@graphiql/plugin-code-exporter Patch
@graphiql/plugin-explorer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2023

The latest changes of this PR are available as canary in npm (based on the declared changesets):

graphiql@3.0.4-canary-72409214.0
@graphiql/plugin-code-exporter@0.3.3-canary-72409214.0
@graphiql/plugin-explorer@0.3.3-canary-72409214.0
@graphiql/react@0.19.2-canary-72409214.0

@codecov
Copy link

codecov bot commented Jul 23, 2023

Codecov Report

Merging #3364 (14c1972) into main (d381436) will not change coverage.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3364   +/-   ##
=======================================
  Coverage   55.69%   55.69%           
=======================================
  Files         110      110           
  Lines        5237     5237           
  Branches     1425     1425           
=======================================
  Hits         2917     2917           
  Misses       1896     1896           
  Partials      424      424           
Impacted Files Coverage Δ
.../graphiql-react/src/explorer/components/search.tsx 62.96% <33.33%> (ø)

@acao acao changed the title search dropdown click #3307 search dropdown click Jul 23, 2023
@acao acao force-pushed the fix-onfocus-3307 branch 3 times, most recently from 612b62f to 539814e Compare July 23, 2023 11:07
@acao acao changed the title search dropdown click fix search dropdown click Jul 23, 2023
@acao acao force-pushed the fix-onfocus-3307 branch 2 times, most recently from a482175 to 58e657a Compare July 24, 2023 14:24
@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for graphiql-test ready!

Name Link
🔨 Latest commit 14c1972
🔍 Latest deploy log https://app.netlify.com/sites/graphiql-test/deploys/64be92e57f95850008632ab1
😎 Deploy Preview https://deploy-preview-3364--graphiql-test.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@acao acao force-pushed the fix-onfocus-3307 branch from 65b3a90 to 14c1972 Compare July 24, 2023 15:03
@acao acao merged commit d67c13f into main Jul 24, 2023
@acao acao deleted the fix-onfocus-3307 branch July 24, 2023 15:40
@acao acao mentioned this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[graphiql] Searching in documentation explorer does not work with manual click
1 participant