Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilise Lighthouse line numbers #123

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Stabilise Lighthouse line numbers #123

merged 3 commits into from
Jun 6, 2024

Conversation

spawnia
Copy link
Member

@spawnia spawnia commented Jun 6, 2024

As discussed in #121 (comment), this pull request should mostly stabilise the line numbers produced in the Lighthouse audit report.

.github/workflows/audits.yml Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
implementations/lighthouse/Dockerfile Show resolved Hide resolved
Copy link
Member

@enisdenjo enisdenjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thank you.

implementations/lighthouse/docker-compose.yml Show resolved Hide resolved
@enisdenjo enisdenjo merged commit 56d11b0 into graphql:main Jun 6, 2024
26 checks passed
@spawnia spawnia deleted the stablise-lighthouse-line-numbers branch June 6, 2024 12:49
@spawnia
Copy link
Member Author

spawnia commented Jun 6, 2024

Thanks for looking into this with me @enisdenjo, feel free to ping me if Lighthouse acts up again.

@enisdenjo
Copy link
Member

🎉 This PR is included in version 1.22.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@enisdenjo enisdenjo added the released Has been released and published label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Has been released and published
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants