Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the todo, warning sign not rendered #126

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

h3ssan
Copy link
Contributor

@h3ssan h3ssan commented Aug 26, 2024

Overview

Fix the todo of rendering the unicode character as different one, since ( ⚠️ ) it's not widely supported across the browsers, therefore I used ( ❗️ ) instead, since it's widely supported across all browsers.

Screenshots

Old Code

old code

Newer Code

new code

Copy link
Member

@enisdenjo enisdenjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers @h3ssan, you're doing a great job with all the PRs! We are very grateful.

Copy link
Member

@enisdenjo enisdenjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the test snapshots.

@h3ssan
Copy link
Contributor Author

h3ssan commented Aug 27, 2024

Please update the test snapshots.

Done, thank you

@h3ssan h3ssan requested a review from enisdenjo August 27, 2024 10:27
@enisdenjo enisdenjo merged commit a1cc086 into graphql:main Aug 27, 2024
24 of 27 checks passed
@h3ssan h3ssan deleted the fix/todo-warning-sign-not-rendered branch August 27, 2024 10:39
@enisdenjo
Copy link
Member

🎉 This PR is included in version 1.22.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@enisdenjo enisdenjo added the released Has been released and published label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Has been released and published
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants