Add recipe to audit servers with Deno #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spawnia
commented
Mar 21, 2023
spawnia
added a commit
to nuwave/lighthouse
that referenced
this pull request
Mar 21, 2023
|
Weird, v16.6.0 on esm.sh indeed does not have the necessary export: https://esm.sh/v111/graphql@16.6.0/deno/graphql.js. However, v16.5.0 has it: https://esm.sh/v111/graphql@16.5.0/deno/graphql.js. What changed? 🤔 |
|
🎉 This PR is included in version 1.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to setup audit tests as described in the Jest example, but found the setup of Jest itself quite cumbersome. Thus, I tried to see if Deno was simpler.
Unfortunately, the example does not work as of now. You can try writing the example code to a filetest.tsand run it withdeno test test.ts. I am currently getting the following error:I found that using npm specifiers fixes the above mentioned error with the missing export.