Skip to content

Commit

Permalink
Drop support for node14
Browse files Browse the repository at this point in the history
Motivation: technically node14 end of life will happen in two months so we can still support it but it creates problems with #3791
Node14 doesn't support `AbortSignal` and since we want to allow resolvers to be canceled we need to expose this object through our public API (inside `info` argument).
Potentialy this and all the other issues (e.g. how to test this feature on node14) can be worked around but complicates solution.
So I think, it worth to deprecate node14 two months earlier in order to unblock #3791 especially since we still in alpha stage.

Less critical but still significant problem with node14 is that it ships with npm6 which doesn't support default format of the lockfile
used by npm9 and this make updating dependencies trickier.
  • Loading branch information
IvanGoncharov committed Feb 23, 2023
1 parent 8313944 commit be06750
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 13,642 deletions.
2 changes: 1 addition & 1 deletion .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ module.exports = {
'prefer-exponentiation-operator': 'error',
'prefer-named-capture-group': 'off', // TODO: needs a better support in TS, see https://github.com/microsoft/TypeScript/issues/32098
'prefer-numeric-literals': 'error',
'prefer-object-has-own': 'off', // TODO: requires Node.js v16.9.0
'prefer-object-has-own': 'error',
'prefer-object-spread': 'error',
'prefer-promise-reject-errors': 'error',
'prefer-regex-literals': 'error',
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node_version_to_setup: [14, 16, 18]
node_version_to_setup: [16, 18, 19]
permissions:
contents: read # for actions/checkout
steps:
Expand Down
Loading

0 comments on commit be06750

Please sign in to comment.