-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Lackluster Documentation #1368
Comments
Totally agree. Adding and improving documentation is the most valuable thing a new contributor can do. Writing documentation for some part of the library is also a great way to learn that area and gain expertise |
Would happily contribute to improve this, is my current sticking point coming back to gql after a long break, but not even sure I know how to do it "right". Does anyone know where the relevant info currently is, and what format it should be in? |
For API-level documentation, I would love to see an automated tool which extracts flow types and comments to produce good documentation. The biggest issue with API docs is keeping them in sync with code. Having the docs live in the code solves this problem and makes the code easier to read. Any contributors who want to take this on will have my support and respect. A slightly less ambitious but still highly impactful effort would be to move the docs into this repo. Right now they are part of the graphql.org repo and that doesn’t make any sense and makes keeping them up to date all the more cumbersome. |
Not sure if anyone is currently working on the above but I'd be down to work on
that |
@AdamT213 Thank you for volunteering 👍 |
Makes sense. I'll keep an eye out for when the issue starts getting some action again. |
The docs have now been copied across and are available in the docs folder. #1923 Thanks @IvanGoncharov These are still as they were on https://graphql.org/learn/ with the schema in a template string, but it is a start. |
Updates on this? Recently started using GraphQL and the struggle has been real. |
This provides people with the option to choose between the template approach or the classes approach. This is a proposal to tackle #1368 [Preview](https://graphql-7w0ort26u-the-graph-ql-foundation.vercel.app/) This has been applied throughout the codebase now, however one of the things I am uncertain about is how we offer `buildSchema` with the GraphQLDefer/... directives? Should we add an option to `buildSchema`? The exports defined in that chapter seem to only exist in v17 so we should explicitly flag that.
This provides people with the option to choose between the template approach or the classes approach. This is a proposal to tackle graphql#1368 [Preview](https://graphql-7w0ort26u-the-graph-ql-foundation.vercel.app/) This has been applied throughout the codebase now, however one of the things I am uncertain about is how we offer `buildSchema` with the GraphQLDefer/... directives? Should we add an option to `buildSchema`? The exports defined in that chapter seem to only exist in v17 so we should explicitly flag that.
Documentation
i've so far seen quite a lot of questions revolving around documentation, specific to the graphql-js implementation and how to translate graphql schemas to the graphql-types.
GraphQLObjectType
, orGraphQLSchema
to define schemas but uses a template string instead.GraphQLDirective
is not even mentioned in the API Reference, which is extremely confusing when trying to wrap your head around how to use graphql properly with graphql-js.i'm not experienced enought to create a pull request for this, but I think the javascript community would greatly benefit from better documentation on how the javascript specific implementation works with graphql.
and since the graphql-js package already exists, it makes no sense to just omit the documentation
#446 #811 #799
The text was updated successfully, but these errors were encountered: