Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validateSchema doesn't use nodes from new extensionASTNodes properties #1387

Closed
leebyron opened this issue Jun 12, 2018 · 0 comments
Closed

validateSchema doesn't use nodes from new extensionASTNodes properties #1387

leebyron opened this issue Jun 12, 2018 · 0 comments
Assignees
@IvanGoncharov
Labels
bug help wanted

Comments

@leebyron
Copy link
Contributor

As mentioned in #1383 - validateSchema currently misses extended properties added in #1373
@leebyron leebyron added this to the v14.0 milestone Jun 12, 2018
@IvanGoncharov IvanGoncharov self-assigned this Jun 14, 2018
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this issue Jun 30, 2018
@IvanGoncharov
validateSchema: use nodes from new extensionASTNodes properties
4245798 
Fixes graphql#1387
@IvanGoncharov IvanGoncharov mentioned this issue Jun 30, 2018
Merged
mjmahone pushed a commit that referenced this issue Jul 17, 2018
@IvanGoncharov @mjmahone
Validate schema use new extension ast nodes (#1410)
d57bdc7 
* Switch 'forEach' to 'for of'

* Add 'getAllSubNodes' utility function

* validateSchema: use nodes from new extensionASTNodes properties

Fixes #1387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IvanGoncharov IvanGoncharov

Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leebyron @IvanGoncharov