Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate literals in a single rule with finer precision #1144

Merged
merged 1 commit into from
Dec 14, 2017
Merged

Validate literals in a single rule with finer precision #1144

merged 1 commit into from
Dec 14, 2017

Commits on Dec 14, 2017

  1. Validate literals in a single rule with finer precision 

    This generalizes the "arguments of correct type" and "default values of correct type" to a single rule "values of correct type" which has been re-written to rely on a traversal rather than the utility function `isValidLiteralValue`. To reduce breaking scope, this does not remove that utility even though it's no longer used directly within the library. Since the default values rule included another validation rule that rule was renamed to a more apt "variable default value allowed".

This also includes the original errors from custom scalars in the validation error output, solving the remainder of #821.

Closes #821
    @leebyron
    leebyron committed Dec 14, 2017
    Configuration menu
    Copy the full SHA
    ae7cd24 View commit details
    Browse the repository at this point in the history