Execute: Remove excessive arguments #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
requested changes
Mar 5, 2018
src/execution/execute.js
Outdated
| fieldNodes[0], | ||
| exeContext.variableValues, | ||
| info.fieldNodes[0], | ||
| info.variableValues, |
There was a problem hiding this comment.
Info should be opaque to the executor internals - it's only used to pass into resolvers. These two should be either passed in directly as arguments or pulled from exeContext
src/execution/execute.js
Outdated
| if (isPromise(completed)) { | ||
| return completed.then(undefined, error => | ||
| Promise.reject( | ||
| locatedError( | ||
| asErrorInstance(error), | ||
| fieldNodes, | ||
| info.fieldNodes, |
There was a problem hiding this comment.
Similarly here - the fieldNodes value is an important argument to the completeValue functions - it should be passed directly instead of extracted from the info passed to resolvers
IvanGoncharov
force-pushed
the
cleanupExecute
branch
from
03573bf to
6d8e214
Compare
|
@leebyron I removed all changes that used data from the |
leebyron
approved these changes
Mar 29, 2018
|
Great! |
This was referenced Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using benchmark, I didn't measure any performance difference.