-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix npm@6 warnings about deprecated "prepublish" #1340
Conversation
@mjmahone Thanks. |
@IvanGoncharov did my squash-and-merge give you the proper attribution? I want to make sure I'm not rewriting pull-request owners somehow, and that you're getting due credit for anything we pull in! If I did mess things up, I'm sorry and will happily change my merge flow. Also thank you for this fix! |
@mjmahone Everything is fine it's look like this: |
Maybe it'd be good to support npm prepare script which can just be a reference to npm build |
@intellix Why would you need to build Or do you need it for something else? |
It'd support bleeding edge without requiring a special branch. You could install any branch like: It won't build a dist upon npm install, it'll just support the above without any consequence or complexities. It's new since npm 5 |
@intellix I wrote a pretty long response but I don't want it to be lost inside merged PR with an unrelated title. |
@intellix Short version: for this to work we need to make |
woohoo! |
NPM 6 produces this warning:
Yarn/NPM support new
prepublishOnly
property:Currently NPM deploy done using:
graphql-js/.travis.yml
Line 34 in 2eccaad
which use NPM 5.