Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps #1444

Merged
merged 1 commit into from
Aug 2, 2018
Merged

Update deps #1444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .flowconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,4 @@ suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(<VERSION>\\)?)\\)
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(<VERSION>\\)?)\\)?:? #[0-9]+

[version]
^0.76.0
^0.77.0
36 changes: 18 additions & 18 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,34 +48,34 @@
"iterall": "^1.2.2"
},
"devDependencies": {
"@babel/cli": "7.0.0-beta.53",
"@babel/core": "7.0.0-beta.53",
"@babel/node": "7.0.0-beta.53",
"@babel/plugin-proposal-class-properties": "7.0.0-beta.53",
"@babel/plugin-proposal-object-rest-spread": "7.0.0-beta.53",
"@babel/plugin-syntax-async-generators": "7.0.0-beta.53",
"@babel/plugin-transform-classes": "7.0.0-beta.53",
"@babel/plugin-transform-destructuring": "7.0.0-beta.53",
"@babel/plugin-transform-flow-strip-types": "7.0.0-beta.53",
"@babel/plugin-transform-modules-commonjs": "7.0.0-beta.53",
"@babel/plugin-transform-spread": "7.0.0-beta.53",
"@babel/polyfill": "7.0.0-beta.53",
"@babel/preset-env": "7.0.0-beta.53",
"@babel/register": "7.0.0-beta.53",
"@babel/cli": "7.0.0-beta.55",
"@babel/core": "7.0.0-beta.55",
"@babel/node": "7.0.0-beta.55",
"@babel/plugin-proposal-class-properties": "7.0.0-beta.55",
"@babel/plugin-proposal-object-rest-spread": "7.0.0-beta.55",
"@babel/plugin-syntax-async-generators": "7.0.0-beta.55",
"@babel/plugin-transform-classes": "7.0.0-beta.55",
"@babel/plugin-transform-destructuring": "7.0.0-beta.55",
"@babel/plugin-transform-flow-strip-types": "7.0.0-beta.55",
"@babel/plugin-transform-modules-commonjs": "7.0.0-beta.55",
"@babel/plugin-transform-spread": "7.0.0-beta.55",
"@babel/polyfill": "7.0.0-beta.55",
"@babel/preset-env": "7.0.0-beta.55",
"@babel/register": "7.0.0-beta.55",
"babel-eslint": "8.2.6",
"babel-plugin-syntax-async-functions": "6.13.0",
"beautify-benchmark": "0.2.4",
"benchmark": "2.1.4",
"chai": "4.1.2",
"coveralls": "3.0.2",
"eslint": "5.1.0",
"eslint": "5.2.0",
"eslint-plugin-babel": "5.1.0",
"eslint-plugin-flowtype": "2.50.0",
"eslint-plugin-prettier": "2.6.2",
"flow-bin": "0.76.0",
"flow-bin": "0.77.0",
"mocha": "5.2.0",
"nyc": "12.0.2",
"prettier": "1.13.7",
"sane": "2.5.2"
"prettier": "1.14.0",
"sane": "3.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How valuable is the sane upgrade? I know we would be stuck on 2.5 for a very long time if we don't upgrade it now, but the release nodes for 3.0 have nothing in them, which makes me think they bumped to 3.0 just so they could stop supporting node v9.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjmahone It's only a dev dependency and we use it only for yarn watch which is broken anyway.
So I can easily revert it but as I wrote in #1445 I don't see any problem with dropping Node 9

}
}
11 changes: 7 additions & 4 deletions src/subscription/__tests__/subscribe-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,10 +882,13 @@ describe('Subscription Publish Phase', () => {
});

it('should pass through error thrown in source event stream', async () => {
const erroringEmailSchema = emailSchemaWithResolvers(async function*() {
yield { email: { subject: 'Hello' } };
throw new Error('test error');
}, email => email);
const erroringEmailSchema = emailSchemaWithResolvers(
async function*() {
yield { email: { subject: 'Hello' } };
throw new Error('test error');
},
email => email,
);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results from prettier update


const subscription = await subscribe(
erroringEmailSchema,
Expand Down
Loading