Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeInfo-test: use proper test name #2444

Merged
merged 1 commit into from
Feb 8, 2020

Conversation

Cito
Copy link
Member

@Cito Cito commented Feb 8, 2020

test name has been duplicated and not adapted

@IvanGoncharov
Copy link
Member

@Cito Was really concentrated on achieving 100% coverage so I lost quality in the process.
Thanks a lot 👍

@IvanGoncharov IvanGoncharov merged commit b55b575 into graphql:master Feb 8, 2020
@Cito
Copy link
Member Author

Cito commented Feb 8, 2020

It's always great to have complete test coverage, thanks for your effort to reach that.

@Cito Cito deleted the fix-type-info-test-name branch February 8, 2020 14:00
@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants