Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export TypeKind as value #3178

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Conversation

janicduplessis
Copy link
Contributor

TypeKind is currently exported as a type in type/index.ts but then re-exported as a value in index.ts. This causes the following error in webpack since type export are removed.

ERROR in ../../node_modules/graphql/index.mjs 32:0-128:26
export 'TypeKind' (reexported as 'TypeKind') was not found in './type/index.mjs'

TypeKind seems to be a value so I changed it to be exported as a value in type/index.ts.

Tested that this fixes the issue in an app.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 14, 2021

CLA Signed

The committers are authorized under a signed CLA.

@IvanGoncharov
Copy link
Member

@janicduplessis Thanks for reporting 👍
I will look into it today.

@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Jun 16, 2021
@IvanGoncharov IvanGoncharov merged commit 40db639 into graphql:main Jun 16, 2021
@IvanGoncharov
Copy link
Member

@janicduplessis Thanks a lot for a fix!
I'm working on adding Webpack to our integration tests so we can prevent this from happening in the future.

@janicduplessis janicduplessis deleted the patch-1 branch June 16, 2021 07:57
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this pull request Jun 18, 2021
IvanGoncharov added a commit that referenced this pull request Jun 20, 2021
Drama123543 added a commit to view-code/graphql-js that referenced this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants