-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add message that we only support TS >= 4.1.0" #3338
Conversation
This reverts commit 7c6bf48.
@IvanGoncharov what is context of original change? I took a look at referenced issue microsoft/TypeScript#44795 — a fix seems in with version 4.5, what is connection to 4.1? |
@saihaj Without this change users will get a long list (41 errors) of parsing errors: The idea behind #3319 was to improve DX and save us from surprised users who will open issues on our repo. |
@yaacovCR Good catch!
TS has no mechanism to specify minimally supported versions, moreover, it prints a bunch of parsing errors and that's very confusing behavior especially for inexperienced devs. |
In that case shouldn’t it be greater than some TS version instead of less than? |
That change imposed an unnecessary restrictions on packages dependant on
graphql
to use older versions of TS.Reverts #3319