Include possible field, argument, type names when validation fails #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 10997c5 on namesuggestions into * on master*. |
| @@ -0,0 +1,78 @@ | |||
| /* @flow */ | |||
There was a problem hiding this comment.
this file should go in the jsutils folder - that is where we keep the dependency-free JS utilities that are not specific to graphql, just happen to be used here.
|
This is looking awesome! |
…options, remove redundant warning
|
Changes Unknown when pulling 8982f88 on namesuggestions into * on master*. |
| expect(suggestionList('input', [])).to.deep.equal([]); | ||
| }); | ||
|
|
||
| it('Returns options sorted based on simularity', () => { |
|
@yuzhi This will be helpful! |
|
Changes Unknown when pulling 5a9fb1e on namesuggestions into * on master*. |
|
@leebyron thoughts on the update? |
|
Most excellent |
sogko
added a commit
to sogko/graphql-js
that referenced
this pull request
Jun 1, 2016
- Test should had broke for changes in graphql#355 which improved validation messages with suggestions. - But `expect().to.deep.equal()` checks for the right number of errors but does not check for equality of error messages.
This was referenced Jun 15, 2016
leebyron
pushed a commit
that referenced
this pull request
Jul 6, 2016
) - Test should had broke for changes in #355 which improved validation messages with suggestions. - But `expect().to.deep.equal()` checks for the right number of errors but does not check for equality of error messages.
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if one misspelled something or flipped the order of words, GraphQL validation does not give any suggestions. Engineers would have to go through the schema to find the valid field/type/argument or check in GraphiQL. This should give useful suggestions for most of these cases so engineers can perform the proper fix much faster.